fix(AddTeamToCodeowners): skip file generation if team name invalid

Closes #49
openrewrite · Sep 2, 2023 · fdd92ee · fdd92ee
1 parent cb7d9f1
commit fdd92ee
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 1 deletion.
diff --git a/src/main/java/org/openrewrite/jenkins/github/AddTeamToCodeowners.java b/src/main/java/org/openrewrite/jenkins/github/AddTeamToCodeowners.java
@@ -80,7 +80,7 @@ public Tree visit(@Nullable Tree tree, ExecutionContext executionContext, Cursor
 
     @Override
     public Collection<? extends SourceFile> generate(Scanned acc, ExecutionContext ctx) {
-        if (acc.foundFile) {
+        if (acc.foundFile || !acc.hasValidTeamName()) {
             return Collections.emptyList();
         }
         PlainTextParser parser = new PlainTextParser();

diff --git a/src/test/java/org/openrewrite/jenkins/github/AddTeamToCodeownersTest.java b/src/test/java/org/openrewrite/jenkins/github/AddTeamToCodeownersTest.java
@@ -220,6 +220,29 @@ void shouldNoOpIfInvalidTeamGenerated() {
         );
     }
 
+    @Test
+    void shouldNoOpIfInvalidTeamGeneratedAndCodeownersFileAbsent() {
+        rewriteRun(
+          pomXml("""
+            <project>
+                <parent>
+                    <groupId>org.jenkins-ci.plugins</groupId>
+                    <artifactId>plugin</artifactId>
+                    <version>4.72</version>
+                </parent>
+                <artifactId>tool-labels-plugin</artifactId>
+                <version>0.1</version>
+                <repositories>
+                    <repository>
+                        <id>repo.jenkins-ci.org</id>
+                        <url>https://repo.jenkins-ci.org/public/</url>
+                    </repository>
+                </repositories>
+            </project>
+            """)
+        );
+    }
+
     @Test
     void shouldNotModifyNonCodeowners() {
         rewriteRun(