Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update file description #15

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Update file description #15

merged 3 commits into from
Jan 20, 2025

Conversation

ghar1821
Copy link
Contributor

@ghar1821 ghar1821 commented Jan 20, 2025 •
edited
Loading

Describe your changes

Make file description clearer in yaml file.

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes

  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

@ghar1821 ghar1821 requested a review from rcannood January 20, 2025 00:39
LuLeom
LuLeom reviewed Jan 20, 2025
View reviewed changes
Copy link
Contributor

@LuLeom LuLeom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I think your changes improved our current descriptions :)

rcannood
rcannood approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks!

@ghar1821 Could you rerun scripts/create_readme.sh to render the updated readme? 🙇

@ghar1821
Copy link
Contributor Author

Overall, I think your changes improved our current descriptions :)

I've updated the description for validation as you suggested :)

@ghar1821 ghar1821 merged commit db4f9e2 into main Jan 20, 2025
2 checks passed
@ghar1821 ghar1821 deleted the update_file_description branch January 20, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuLeom LuLeom LuLeom left review comments

@rcannood rcannood rcannood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ghar1821 @rcannood @LuLeom