Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arguments for filtering methods in benchmark workflow #4

Merged
merged 6 commits into from
Oct 22, 2024

Conversation

lazappi
Copy link
Contributor

@lazappi lazappi commented Oct 16, 2024

Describe your changes

Add arguments to the benchmark workflow that methods to be either included or excluded

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions

src/workflows/run_benchmark/main.nf Outdated Show resolved Hide resolved
src/workflows/run_benchmark/main.nf Outdated Show resolved Hide resolved
src/workflows/run_benchmark/config.vsh.yaml Outdated Show resolved Hide resolved
src/workflows/run_benchmark/config.vsh.yaml Outdated Show resolved Hide resolved
src/workflows/run_benchmark/config.vsh.yaml Outdated Show resolved Hide resolved
@lazappi lazappi marked this pull request as ready for review October 17, 2024 07:19
… into feature/no-ref/method-selection

* origin/feature/no-ref/method-selection:
  Move checkMethodAllowed Nexflow helper to common
Copy link
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rcannood rcannood merged commit 4cb77a4 into main Oct 22, 2024
2 checks passed
@rcannood rcannood deleted the feature/no-ref/method-selection branch October 22, 2024 13:29
lazappi added a commit that referenced this pull request Oct 23, 2024
…neformer

* origin/main:
  Add arguments for filtering methods in benchmark workflow (#4)
  Add SCimilarity (#3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants