Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable BigInt/BigFloat support, we need to added CONFIG_BIGNUM to binary build.
Because qjsc compile code to bytecodes with specific length, with CONFIG_BIGNUM enable, the bytes length is different.
When we use prebuild codes included to WebF or Kraken, especially using javascript polyfill. The code will not be evaluated because ByteCode version is different according to
https://github.com/openwebf/webf/blob/80f32ab9856c7d69ef1ff778e083a323f4f83f51/bridge/third_party/quickjs/src/core/bytecode.c#L2027
Either we should include node-qjsc to WebF and pass different settings before polyfill scripts build. or we should create different binary here.
Just create this pull request to provide you guys to consider. Thanks