Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added CONFIG_BIGNUM #18

Merged
merged 1 commit into from
Sep 29, 2022
Merged

added CONFIG_BIGNUM #18

merged 1 commit into from
Sep 29, 2022

Conversation

neeboo
Copy link
Contributor

@neeboo neeboo commented Sep 28, 2022

To enable BigInt/BigFloat support, we need to added CONFIG_BIGNUM to binary build.

Because qjsc compile code to bytecodes with specific length, with CONFIG_BIGNUM enable, the bytes length is different.

When we use prebuild codes included to WebF or Kraken, especially using javascript polyfill. The code will not be evaluated because ByteCode version is different according to
https://github.com/openwebf/webf/blob/80f32ab9856c7d69ef1ff778e083a323f4f83f51/bridge/third_party/quickjs/src/core/bytecode.c#L2027

Either we should include node-qjsc to WebF and pass different settings before polyfill scripts build. or we should create different binary here.

Just create this pull request to provide you guys to consider. Thanks

@andycall
Copy link
Member

LGTM

I will help to ship a new minor version of node-qjsc.

@andycall andycall merged commit e41b8ac into openkraken:main Sep 29, 2022
@andycall
Copy link
Member

Maybe this Issue could be fixed.

#17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants