Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317636: Improve heap walking API tests to verify correctness of field indexes #3200

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 10, 2025

I backport this for parity with 21.0.7-oracle.

I think it is useful in 17, too.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317636 needs maintainer approval

Issue

  • JDK-8317636: Improve heap walking API tests to verify correctness of field indexes (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3200/head:pull/3200
$ git checkout pull/3200

Update a local copy of the PR:
$ git checkout pull/3200
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3200

View PR using the GUI difftool:
$ git pr show -t 3200

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3200.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 10, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f31957e6a1c463e5c7041bf4eee4a1b09048e929 8317636: Improve heap walking API tests to verify correctness of field indexes Jan 10, 2025
@openjdk
Copy link

openjdk bot commented Jan 10, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jan 10, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 10, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 10, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant