8311663: Additional refactoring of Locale tests to JUnit #3196
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/jdk/java/util/Locale/Bug8135061.java
test/jdk/java/util/Locale/Bug8159420.java
test/jdk/java/util/Locale/ThaiGov.java
These three need to be resolved because
"8283698: Refactor Locale constructors used in src/test" is not in 17.
Basically I took over the head version of the test in 21, and reverted the refactored constructor call.
test/jdk/java/util/Locale/UseOldISOCodesTest.java
is not in 17. It was added by "8295232: "java.locale.useOldISOCodes" property is read lazily".
As I understand the error fixed by JDK-8295232 was introduced by closed JDK-8294667. I built
jdk20 before JDK-8295232 was pushed, this causes the test to fail.
With 17 and 20 after this change it passes. I would like to take the test to 17 to
improve testing along with this change. This would also alert us if a change breaking
this is backported.
As with the changes above I had to undo JDK-8283698.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3196/head:pull/3196
$ git checkout pull/3196
Update a local copy of the PR:
$ git checkout pull/3196
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3196/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3196
View PR using the GUI difftool:
$ git pr show -t 3196
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3196.diff
Using Webrev
Link to Webrev Comment