Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311663: Additional refactoring of Locale tests to JUnit #3196

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Jan 9, 2025

test/jdk/java/util/Locale/Bug8135061.java
test/jdk/java/util/Locale/Bug8159420.java
test/jdk/java/util/Locale/ThaiGov.java

These three need to be resolved because
"8283698: Refactor Locale constructors used in src/test" is not in 17.
Basically I took over the head version of the test in 21, and reverted the refactored constructor call.

test/jdk/java/util/Locale/UseOldISOCodesTest.java

is not in 17. It was added by "8295232: "java.locale.useOldISOCodes" property is read lazily".
As I understand the error fixed by JDK-8295232 was introduced by closed JDK-8294667. I built
jdk20 before JDK-8295232 was pushed, this causes the test to fail.
With 17 and 20 after this change it passes. I would like to take the test to 17 to
improve testing along with this change. This would also alert us if a change breaking
this is backported.
As with the changes above I had to undo JDK-8283698.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8311663 needs maintainer approval

Issue

  • JDK-8311663: Additional refactoring of Locale tests to JUnit (Sub-task - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3196/head:pull/3196
$ git checkout pull/3196

Update a local copy of the PR:
$ git checkout pull/3196
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3196

View PR using the GUI difftool:
$ git pr show -t 3196

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3196.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 9, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 9, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 71cac8ce47b69a2b78d54cbceb0f0510e5ea4cdc 8311663: Additional refactoring of Locale tests to JUnit Jan 9, 2025
@openjdk
Copy link

openjdk bot commented Jan 9, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 9, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 9, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant