8314225: SIGSEGV in JavaThread::is_lock_owned

[GoeLin]

I backport this for parity with 17.0.15-oracle.

I had to resolve the larger part of this change.
None of my edits change the code essentially, though.

src/hotspot/share/jfr/leakprofiler/checkpoint/rootResolver.cpp
Resolved because of NULL/nullptr difference

src/hotspot/share/runtime/javaThread.cpp|hpp
These files don't exist in 17, they were split off from thread.cpp|hpp.
The modiefied code looks very similar in 17, so I could easily identify
the changed code and apply the patches. Usual minor nullptr diffs etc.

src/hotspot/share/runtime/monitorChunk.cpp
Resolved because of NULL/nullptr difference

src/hotspot/share/runtime/monitorChunk.hpp
Resolved because of context diff.

src/hotspot/share/runtime/synchronizer.cpp
Resolved. Different checks in if condition.
One is for the new locking mode in head, the other whether the mask has a locker.
... check ...

src/hotspot/share/runtime/thread.cpp
Resolved because new locking modes added an assertion in removed function is_lock_owned.

src/hotspot/share/runtime/vframeArray.cpp
Resolved. Code differs because 21 has biased locking removed.

To make it build, I had to replace
Javathread::cast() by as_Java_thread() in synchronizer.cpp.

Also I removed is_linked() from monitorChunk.hpp.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8314225 needs maintainer approval

Issue

• JDK-8314225: SIGSEGV in JavaThread::is_lock_owned (Bug - P2 - Approved)

Reviewers

• Richard Reingruber (@reinrich - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3177/head:pull/3177
$ git checkout pull/3177

Update a local copy of the PR:
$ git checkout pull/3177
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3177/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3177

View PR using the GUI difftool:
$ git pr show -t 3177

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3177.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314225: SIGSEGV in JavaThread::is_lock_owned

Reviewed-by: rrich

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 53d7539: 8336942: Improve test coverage for class loading elements with annotations of different retentions
• 96100ad: 8293412: Remove unnecessary java.security.egd overrides
• 34fd121: 8339524: Clean up a few ExtendedRobot tests
• 255a4aa: 8340719: Open source AWT List tests
• ca90fda: 8340480: Bad copyright notices in changes from JDK-8339902
• 69f0b90: 8316559: Refactor some util/Calendar tests to JUnit
• 552e3cb: 8306711: Improve diagnosis of IntlTest framework
• 0d21d0a: 8296591: Signature benchmark
• aedd0be: 8343101: Rework BasicTest.testTemp test cases
• e0b1651: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above
• ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/d929b803836436314a62ede766467d3b436e00ff...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (1787bca4)
• 00: Full (c69d97a7)

[reinrich]

Looks good besides one assertion message that could be improved.

[reinrich]

Suggested change

	assert(!monitor->owner()->is_unlocked() && !monitor->owner()->has_bias_pattern(), "object must be null or locked, and unbiased");
	assert(!monitor->owner()->is_unlocked() && !monitor->owner()->has_bias_pattern(), "object must be locked, and unbiased");

[GoeLin]

Thanks for catching this, makes sense. Fixed.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.