-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport jdk 8341779 #3038
base: master
Are you sure you want to change the base?
Backport jdk 8341779 #3038
Conversation
👋 Welcome back cushon! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
7097e97
to
4965dd9
Compare
Thank you for providing this draft. I replicated the crash in my environment, confirmed the lines added to the test are required to trigger the crash, and confirmed that reverting "Disable handling of annotations with different retention at the same location" fixes the crash. |
@cushon This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Progress
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3038/head:pull/3038
$ git checkout pull/3038
Update a local copy of the PR:
$ git checkout pull/3038
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3038/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 3038
View PR using the GUI difftool:
$ git pr show -t 3038
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3038.diff