Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a convenience method for constructing a
time.toInstant
from various input types, similar totime.toZDT
.The main purpose and motivation is to simplify this:
to the more straight-forward (and faster):
Please note I have deliberately left out a few conversions provided by
time.toZDT
which I consider slightly misleading and/or bloated, for example considering a number to be a number of milliseconds to be added tonow
. This can be achieved by directly using the js-joda classes, e.g.time.Instant.now().plusMillis(500)
which to me seems more readable thantime.toInstant(500)
.I was in doubt whether to even add
time.toInstant()
(without parameter) in favor of usingtime.Instant.now()
, but it seems so commonly used fortime.toZDT
that I decided to leave it in for first review iteration to be discussed. I also provided those operations working directly on items, although I also have doubts aboutDecimalType
andQuantityType
.Testing
Output:
Resolves #412