Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add column #61

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Fix add column #61

merged 2 commits into from
Dec 2, 2024

Conversation

FlorisCalkoen
Copy link

Hi @cholmes, a small PR to keep scripts updated with new overture releases. Ideally we work towards a package that can almost be used in a CI workflow to postprocess Overture releases so that they are optimized for cloud-native workflows.

In the feb release there was a column called "names" that broke the def process_parquet_file() :

 # NOTE: exclude names column because it's all NULL and causes InternalException: INTERNAL Error: Attempted to dereference unique_ptr that is NULL!
con.execute(f"CREATE OR REPLACE TABLE buildings AS SELECT * EXCLUDE(names) FROM read_parquet('{input_parquet_path}')")

Also I have adjusted the filepaths in the add_columns.py so that they match with the bash script in #60

@cholmes
Copy link
Collaborator

cholmes commented Dec 2, 2024

Sorry for the huge delay, I fell off on this after overture started gaining momentum and adopting GeoParquet, and my github notifications have never really worked for me. I just added a note to the readme to explain. But I really appreciate the contribution, and apologize that I didn't see it until now.

@cholmes cholmes merged commit 98bae66 into opengeos:main Dec 2, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants