-
-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add infos about the photo in the modal sheet (gallery) #6229
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6229 +/- ##
==========================================
- Coverage 9.54% 6.12% -3.43%
==========================================
Files 325 462 +137
Lines 16411 27070 +10659
==========================================
+ Hits 1567 1657 +90
- Misses 14844 25413 +10569 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I have some reservations about the scalability of putting it into the bottom sheet, regarding nutri-patrol
@g123k You can get the source photo id, and then get the contributor |
There are links between photos and contributors. If you find how, please give an example. For the size of this change, this is similar to when we have an outdated picture + from producer. I can change the layout to to make this part only available after a second scroll |
https://world.openfoodfacts.org/api/v3/product/2174616005501.json?fields=images "nutrition_fr": {
|
Okay, my two examples didn't have the information. |
I've changed the behavior to have an expandable container. Video: https://github.com/user-attachments/assets/d24cb623-38f7-429c-a312-b0b31e6efab3 |
@g123k merge conflicts |
Hi everyone!
My initial goal was to display the contributor's name and the date in the modal sheet.
Unfortunately, and correct me if I'm wrong, but the contributor's name is unavailable for the 4 main photos in the API.
Instead, I better show the date (+ outdated) and if the creator is the producer.
Video: user-attachments/assets/d24cb623-38f7-429c-a312-b0b31e6efab3