Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: A valid product needs to have a photo (otherwise -> new) #6191

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Jan 12, 2025

Hi everyone!

If a product is found on the server BUT doesn't have photos, it's considered as new.
It was initially planned with the new design, but we can implement it with the current code.

Video: https://github.com/user-attachments/assets/f45b44ad-c4bf-4ba8-8621-e58875c1b05e

@github-actions github-actions bot added 🥫 Product page 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion… product scan carousel labels Jan 12, 2025
@g123k g123k changed the title feat: A valid product needs to have photos (otherwise -> new) feat: A valid product needs to have a photo (otherwise -> new) Jan 12, 2025
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 6.27%. Comparing base (4d9c7fc) to head (fc29b16).
Report is 649 commits behind head on develop.

Files with missing lines Patch % Lines
...oth_app/lib/data_models/continuous_scan_model.dart 0.00% 12 Missing ⚠️
...es/smooth_app/lib/data_models/fetched_product.dart 0.00% 3 Missing ⚠️
...ib/pages/product/common/product_dialog_helper.dart 0.00% 2 Missing ⚠️
...th_app/lib/pages/search/search_product_helper.dart 0.00% 2 Missing ⚠️
...oth_app/lib/pages/scan/carousel/scan_carousel.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #6191      +/-   ##
==========================================
- Coverage     9.54%   6.27%   -3.28%     
==========================================
  Files          325     456     +131     
  Lines        16411   26309    +9898     
==========================================
+ Hits          1567    1651      +84     
- Misses       14844   24658    +9814     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to think a little bit on this one:

  • Does this work if you're not logged in ?
  • Should we push people in the pipeline if we have no score for food in general?
  • Should we push people in the pipeline if we have badly outdated photos ?
  • Should we integrate Robotoff in editing screens (since pre-computation will already be done in some cases, like category prediction, and even more if we adopt this behaviour more broadly)
  • How do we add cases safely while handling well edge cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥫 Product page product scan carousel 🤳🥫 Scan We need to be able to scan on low-end, old devices, even with a bad camera, connexion…
Projects
Status: 💬 To discuss and validate
Development

Successfully merging this pull request may close these issues.

3 participants