Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 5198 - added a local "latest prices" page #5351

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

monsieurtanuki
Copy link
Contributor

What

  • Added a local "latest prices" page, from the user page.

Screenshots

latest prices page from user page
Screenshot_1718000938 Screenshot_1718000921

Fixes bug(s)

Impacted files

  • app_en.arb: added 1 "product unknown" label
  • app_fr.arb: added 1 "product unknown" label
  • price_data_widget.dart: minor fix
  • price_product_widget.dart: minor improvements
  • user_preferences_account.dart: added a call to a "latest prices" page

Impacted files:
* `app_en.arb`: added 1 "product unknown" label
* `app_fr.arb`: added 1 "product unknown" label
* `price_data_widget.dart`: minor fix
* `price_product_widget.dart`: minor improvements
* `user_preferences_account.dart: added a call to a "latest prices" page
@monsieurtanuki monsieurtanuki requested a review from teolemon June 10, 2024 06:38
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 7.53%. Comparing base (4d9c7fc) to head (019e953).
Report is 173 commits behind head on develop.

Files Patch % Lines
...oth_app/lib/pages/prices/price_product_widget.dart 0.00% 13 Missing ⚠️
...ib/pages/preferences/user_preferences_account.dart 0.00% 12 Missing ⚠️
...smooth_app/lib/pages/prices/price_data_widget.dart 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #5351      +/-   ##
==========================================
- Coverage     9.54%   7.53%   -2.02%     
==========================================
  Files          325     377      +52     
  Lines        16411   18984    +2573     
==========================================
- Hits          1567    1430     -137     
- Misses       14844   17554    +2710     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swell @monsieurtanuki 👍
My feeling currently is that we now need to shift energy towards receipts and multiple price addition

@monsieurtanuki monsieurtanuki merged commit 39c9c43 into openfoodfacts:develop Jun 10, 2024
6 checks passed
@monsieurtanuki
Copy link
Contributor Author

Thank you @teolemon for your review!

Swell @monsieurtanuki 👍 My feeling currently is that we now need to shift energy towards receipts and multiple price addition

Indeed. That's not the easiest part though, as it means an additional barcode scanner instance.
Would you be ok with a first step just typing in the barcodes?

@teolemon
Copy link
Member

Power users could probably use a third party app, so I guess so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Replicate the 'Last added prices' view from the Open Prices web app
3 participants