Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump iOS version to 12 #4823

Merged
merged 1 commit into from
Nov 20, 2023
Merged

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Nov 19, 2023

Hi erveryone,

The package connectivity_plus relies on iOS 12+, that's why we have to bump to this version.
As you can see, the difference between iOS 11 and 12 is really tiny:
Screenshot 2023-11-19 at 22 57 15

https://iosref.com/ios-usage
It will fix #4822

@g123k g123k added 🍎 iOS iOS specific issues or PRs 🍎 cocoapods labels Nov 19, 2023
@g123k g123k requested a review from a team as a code owner November 19, 2023 21:57
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f145c3c) 9.87% compared to head (19c5baa) 9.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #4823   +/-   ##
=======================================
  Coverage     9.87%   9.87%           
=======================================
  Files          312     312           
  Lines        15820   15820           
=======================================
  Hits          1562    1562           
  Misses       14258   14258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teolemon teolemon merged commit c09e94a into openfoodfacts:develop Nov 20, 2023
6 checks passed
@g123k g123k deleted the bump_ios_version branch November 25, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍎 cocoapods 🍎 iOS iOS specific issues or PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS build failing because of connectivity_plus
4 participants