Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RHOAIENG-13566] Configure SSL for the communication between head and worker #346

Open
wants to merge 8 commits into
base: incubating
Choose a base branch
from

Conversation

Jooho
Copy link
Contributor

@Jooho Jooho commented Jan 13, 2025

Description

Between head node and worker node, we should configure certificate for SSL communication.
https://issues.redhat.com/browse/RHOAIENG-13566

How Has This Been Tested?

  • Setup DataScienceCluster with below onfiguration.
apiVersion: datasciencecluster.opendatahub.io/v1
kind: DataScienceCluster
metadata:
  name: default-dsc
spec:
  components:
    codeflare:
      managementState: Removed
    dashboard:
      managementState: Removed
    datasciencepipelines:
      managementState: Removed
    kserve:
      devFlags:
        manifests:
          - contextDir: config
            sourcePath: overlays/odh
            uri: 'https://github.com/opendatahub-io/kserve/tarball/master'
          - contextDir: config
            sourcePath: ''
            uri: 'https://github.com/jooho/odh-model-controller/tarball/ray_tls_by_op_manifests'
      serving:
        ingressGateway:
          certificate:
            type: OpenshiftDefaultIngress
        managementState: Removed
        name: knative-serving
      managementState: Managed
    kueue:
      managementState: Removed
    modelmeshserving:
      managementState: Removed
    ray:
      managementState: Removed
    trainingoperator:
      managementState: Removed
    trustyai:
      managementState: Removed
    workbenches:
      managementState: Removed
  • Create a MultiNode ServingRuntime in a test ns
oc new-project kserve-demo
oc process vllm-multinode-runtime-template -n redhat-ods-applications|oc create -n kserve-demo -f - 
  • Verify ray-tls Secret in kserve-demo and ray-tls-ca secret are created in the redhat-ods-applications

  • download model and create isvc (refer this script)

  • Deploy a model with multi-node feature.

    • It should deploy without any errors.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Jan 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

fix syntax
Signed-off-by: jooho lee <[email protected]>
@Jooho Jooho requested review from israel-hdez and removed request for mwaykole and VedantMahabaleshwarkar January 13, 2025 22:49
Signed-off-by: jooho lee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant