Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added new graph object for nim runtimes #334

Merged

Conversation

TomerFi
Copy link
Contributor

@TomerFi TomerFi commented Dec 11, 2024

Description

Added new graph objects for NIM models.

Work doc
Jira: NVPE-51

Frontend PR: opendatahub-io/odh-dashboard#3612

How Has This Been Tested?

A custom image was deployed into our dev cluster. After deploying a NIM model to the cluster, I checked the relevant x-metrics-dashboard configmap for the graph objects. I proceeded to execute the instantiated queries against the model after loading it with invocations to provide data. See doc for more details.

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

openshift-ci bot commented Dec 11, 2024

Hi @TomerFi. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@VedantMahabaleshwarkar
Copy link
Contributor

/ok-to-test

@spolti
Copy link
Member

spolti commented Jan 9, 2025

@israel-hdez do you want to take a look before we merge it?

@openshift-ci openshift-ci bot added the approved label Jan 9, 2025
Copy link
Contributor

@israel-hdez israel-hdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

openshift-ci bot commented Jan 10, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: israel-hdez, spolti, TomerFi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@israel-hdez
Copy link
Contributor

/lgtm

@openshift-merge-bot openshift-merge-bot bot merged commit 026c60b into opendatahub-io:incubating Jan 10, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants