-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend Vulnerabilities fixed #3626
Conversation
* CVE-2024-55565 odh-dashboard-container: nanoid mishandles non-integer values * CVE-2024-52798 odh-dashboard-container: path-to-regexp Unpatched ReDoS in 0.1.x
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3626 +/- ##
==========================================
- Coverage 85.00% 84.99% -0.01%
==========================================
Files 1404 1404
Lines 32244 32244
Branches 9042 9042
==========================================
- Hits 27408 27406 -2
- Misses 4836 4838 +2 see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gkrumbach07, manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
RHOAIENG-17793
RHOAIENG-17794
Description
How Has This Been Tested?
npm audit
in frontend folder and check for 0 vulnerabilities.Test Impact
None
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main