Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from kubeflow:main #128

Merged
merged 13 commits into from
Sep 30, 2024
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Sep 25, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Al-Pragliola and others added 6 commits September 24, 2024 10:00
…410)

* feat(docs): added documentation about using mr on kind with ingress

Signed-off-by: Alessio Pragliola <[email protected]>

* feat(docs): added link to the ingress guide in CONTRIBUTING.md

Signed-off-by: Alessio Pragliola <[email protected]>

* chore(docs): apply suggestions from code review

Co-authored-by: Matteo Mortari <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]>

* feat(docs): added port forwarding guide

Signed-off-by: Alessio Pragliola <[email protected]>

Co-authored-by: Matteo Mortari <[email protected]>

* chore(docs): apply suggestions from code review

Co-authored-by: Matteo Mortari <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]>

---------

Signed-off-by: Alessio Pragliola <[email protected]>
Signed-off-by: Alessio Pragliola <[email protected]>
Co-authored-by: Matteo Mortari <[email protected]>
…0-prerelease.14 in /clients/ui/frontend (#416)

Bumps [@patternfly/react-core](https://github.com/patternfly/patternfly-react) from 6.0.0-alpha.102 to 6.0.0-prerelease.14.
- [Release notes](https://github.com/patternfly/patternfly-react/releases)
- [Commits](https://github.com/patternfly/patternfly-react/compare/@patternfly/[email protected]...@patternfly/[email protected])

---
updated-dependencies:
- dependency-name: "@patternfly/react-core"
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…end (#418)

Bumps [dompurify](https://github.com/cure53/DOMPurify) and [@types/dompurify](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/dompurify). These dependencies needed to be updated together.

Updates `dompurify` from 2.5.6 to 3.1.6
- [Release notes](https://github.com/cure53/DOMPurify/releases)
- [Commits](cure53/DOMPurify@2.5.6...3.1.6)

Updates `@types/dompurify` from 2.4.0 to 3.0.5
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/dompurify)

---
updated-dependencies:
- dependency-name: dompurify
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: "@types/dompurify"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@openshift-ci openshift-ci bot requested review from lampajr and rareddy September 25, 2024 04:45
Copy link

openshift-ci bot commented Sep 25, 2024

Hi @pull[bot]. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 43.90244% with 23 lines in your changes missing coverage. Please review.

Project coverage is 77.58%. Comparing base (d4bb03f) to head (7990b69).
Report is 138 commits behind head on main.

Files with missing lines Patch % Lines
internal/converter/openapi_reconciler_util.go 0.00% 13 Missing ⚠️
pkg/core/artifact.go 64.28% 5 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
- Coverage   78.23%   77.58%   -0.66%     
==========================================
  Files          23       24       +1     
  Lines        2118     2159      +41     
  Branches      145      145              
==========================================
+ Hits         1657     1675      +18     
- Misses        269      287      +18     
- Partials      192      197       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* fix(csi): prevent race condition in ci tests step

Signed-off-by: Alessio Pragliola <[email protected]>

* chore(csi): reword repeat_cmd_until fail msg

Signed-off-by: Alessio Pragliola <[email protected]>

* refactor(csi): move wait_for_port in test_utils

Signed-off-by: Alessio Pragliola <[email protected]>

---------

Signed-off-by: Alessio Pragliola <[email protected]>
* OAS: add generic artifacts routes

Signed-off-by: Isabella do Amaral <[email protected]>

* OAS: make discriminator explicit as model prop

Signed-off-by: Isabella do Amaral <[email protected]>

* update existing artifact with custom helper

Signed-off-by: Isabella do Amaral <[email protected]>

---------

Signed-off-by: Isabella do Amaral <[email protected]>
ederign and others added 3 commits September 25, 2024 16:03
…/ui/frontend (#419)

Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 29.5.12 to 29.5.13.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest)

---
updated-dependencies:
- dependency-name: "@types/jest"
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Copy link
Member

@tarilabs tarilabs left a comment

Copy link

openshift-ci bot commented Sep 30, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pull[bot], tarilabs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 337bf43 into opendatahub-io:main Sep 30, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants