-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: raise error if generation post>A x capacity #102
Conversation
@peterdudfield, I’ve made the changes to the India client. I believe I’ll need to do the same for dummydb, but in that case, the post function is just a placeholder. Also, could you guide me on how to test the changes? Are there any relevant docs available? I’m currently unable to test them. |
@peterdudfield bumping this up |
|
@peterdudfield i have added the test can you please review pr |
@peterdudfield bumping this up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small change, but otherwise looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for this
@all-contributors please add @suvanbanerjee for code |
I've put up a pull request to add @suvanbanerjee! 🎉 |
Pull Request
Description
Add HTTP 422 exception when trying to post data more than site_capacity_kw*capacity_factor
Fixes #87
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration
If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?
Checklist: