Remove btm spacer, fix scroll bars in modals #1053
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we decided that our modals should be scrollable, some of them always have a scrollbar showing, due to an absolutely positioned white box at the very bottom of the modal. I am not sure what the original purpose of this "btm-spacer" component was supposed to be, but it seems superfluous to me and so I am removing it. This should stop the scrollbars from appearing unnecessarily.
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
|
This pull request is deployed at test.admin-interface.opencast.org/1053/2025-01-10_15-07-53/ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we decided that our modals should be scrollable, some of them always have a scrollbar showing, due to an absolutely positioned white box at the very bottom of the modal. I am not sure what the original purpose of this "btm-spacer" component was supposed to be, but it seems superfluous to me and so I am removing it. This should stop the scrollbars from appearing unnecessarily.
Before:
After:
How to test this
Can be tested as usual