Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code for extended metadata #1045

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Arnei
Copy link
Member

@Arnei Arnei commented Jan 7, 2025

Some of the code used for rendering extended metadata is very similar to the code used for rendering common metadata. This patch attempts to reduce the resulting code duplication a bit.

Includes a logic change on how we store metadata values in formik for new events/series, by storing them the same way extended metadata is stored.

How to test this

To properly test this, an Opencast with extended metadata for events and series is required. You can find more details on how to configure that here: https://docs.opencast.org/develop/admin/#configuration/metadata/#extended-metadata

@Arnei Arnei added the type:code-enhancement Internal improvements to the codebase label Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-1045

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-1045

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

Some of the code used for rendering extended
metadata is very similar to the code used for
rendering common metadata. This patch
attempts to reduce the resulting code duplication
a bit.

Includes a logic change on how we store metadata
values in formik, by storing them the same
way extended metadata is stored.
@Arnei Arnei force-pushed the reduce-duplicate-code-extendend-metadata branch from ec588f8 to 0c7ff62 Compare January 7, 2025 09:21
Copy link
Contributor

github-actions bot commented Jan 7, 2025

This pull request is deployed at test.admin-interface.opencast.org/1045/2025-01-07_09-22-04/ .
It might take a few minutes for it to become available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:code-enhancement Internal improvements to the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant