Fix failed to stat '/root/.gitconfig' issue on gitfs (bsc#1230944) (bsc#1234881) #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sc#1234881) This commit ensures the right HOME value is set during Pygit2 remote initialization, otherwise there are chances that it gets a wrong value depending on the execution stack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR ensures the right value for
HOMEenvironment is set during Pygit2 remote initialization, otherwise there are chances that it gets a wrong value depending on the execution stack.Upstream PR: saltstack/salt#67186
Previous Behavior
The previous way of setting the HOME value for pygit2 gitfs remotes was done at
_fetchfunction, there are chances, i.a. when fetching a non-existing branch, thatHOMEvalue gets wrongly replaced by/root/in the corresponding MWorker, leading to errors like:_pygit2.GitError: /var/cache/salt/master/git_pillar/xxxxx/master: failed to stat '/root/.gitconfig'This error starts happening randomly until all the MWorker processes get the
HOMEvalue polluted and therefore leading always to get this exception when fetching from the gitfs remote.New Behavior
The right value is set for
HOMEenvironment:/var/lib/salt/, and the value gets preserved on the MWorker processes even if there are exceptions fetching non-existing remotes.Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.