Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature download, fix verification description (boo#1211156). #197

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

hramrach
Copy link
Contributor

No description provided.

@tacerus
Copy link
Member

tacerus commented May 31, 2024

Adding all these quotes is unnecessary and not related to the described issue.

@hramrach
Copy link
Contributor Author

They are not causing problem, are they?

It's not like I would add this by hand, and the yaml generator considers the URLs too complex to leave them unquoted.

@tacerus
Copy link
Member

tacerus commented May 31, 2024

They are not, but neither are the strings causing a problem for the YAML parsing unless YAML control characters standing alone are part of the strings, which does not seem to be the case.
I suggest to propose different YAML formatting as a separate patch.

@hramrach
Copy link
Contributor Author

The different yaml formatting is a result of roundtrip through yaml parser/serializer adding the extra lines programatically in-between. It's not intentional change but so long as the result is usable I see no problem with it.

@hellcp
Copy link
Member

hellcp commented May 31, 2024

It makes reviewing actual intended changes difficult, so I disagree it makes no difference

hramrach added 3 commits May 31, 2024 12:26
This adds missing yaml document start line, and quotes URL strings, no
change in content.
@hramrach
Copy link
Contributor Author

The formatting change is now in a separate patch

@hellcp hellcp merged commit 7c915a0 into openSUSE:main Jun 18, 2024
2 checks passed
@hramrach
Copy link
Contributor Author

Looks good, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants