Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support values of union DataTypes. #184

Merged
merged 1 commit into from
Sep 16, 2022

Conversation

MurzynJ
Copy link
Collaborator

@MurzynJ MurzynJ commented Feb 14, 2022

  • Importing a value works, if its DataType has been loaded through the NodesetCompiler before. (Trust me I tested it)
  • Importing of union DataTypes from XML seems to still be broken.

Due to the above it's hard to make a unit test at the moment, as I can't get a DataType into the loader in the first place, without creating a dependency on open62541 code (to get the NodesetCompiler).

It would be useful to have a look in future at importing of union DataTypes.

@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2022

Codecov Report

Merging #184 (b7943d1) into master (6e1da3d) will decrease coverage by 0.51%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   93.42%   92.90%   -0.52%     
==========================================
  Files          57       57              
  Lines        3969     3991      +22     
==========================================
  Hits         3708     3708              
- Misses        261      283      +22     
Impacted Files Coverage Δ
backends/open62541/src/Value.c 81.12% <0.00%> (-10.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e1da3d...b7943d1. Read the comment docs.

Importing the value works, if the DataType itself was loaded through the
NodesetCompiler. Importing of the union DataType from XML seems to still
be broken.
@MurzynJ
Copy link
Collaborator Author

MurzynJ commented Feb 16, 2022

@matkonnerth
Have you had a look at this change? I'm hesitating to merge it yet, because I didn't come up with a good test, that would make a pass through the added code (that's why the coverage % dropped). As I wrote in the fist comment it would be easier to make the test if importing of the Union DataTypes works correctly (see #186).

@matkonnerth
Copy link
Collaborator

Hi @MurzynJ , thanks for your work, importing union datatypes should be fixed now.

@matkonnerth matkonnerth merged commit 0bf42b0 into open62541:master Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants