New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flag -DJSONCPP_USE_SECURE_MEMORY:BOOL=TRUE #1567

Merged

baylesj merged 1 commit into open-source-parsers:master from tfc:master

Sep 12, 2024

Contributor

tfc commented Sep 12, 2024

The Cmake description uses JSONCPP_USE_SECURE_MEMORY and the source uses JSONCPP_USING_SECURE_MEMORY.

Is it known that the tests don't compile with this setting being enabled?


          Fix typo in JSONCPP_USE_SECURE_MEMORY vs JSONCPP_USING_SECURE_MEMORY

a5b69ef

Contributor

baylesj commented Sep 12, 2024

Thanks for catching this. I'll look at adding a new bot configuration that would catch this.

baylesj merged commit 8214f71 into open-source-parsers:master

10 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet