-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhance] Speed up optimizer. #909
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #909 +/- ##
=======================================
Coverage ? 77.74%
=======================================
Files ? 139
Lines ? 11491
Branches ? 2330
=======================================
Hits ? 8934
Misses ? 2147
Partials ? 410
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
It would be better to provide a benchmark of the optimization in the PR message. |
Please add the usage in the |
- ``reduce_param_groups`` (bool): If true, constructor will cluster the | ||
parameter groups with the same learning rate, momentum and other | ||
parameters, which can speed up the optimizer. Defaults to true. | ||
New in version 0.7.2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a newer version number? 0.10.4?
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Speed up optimization progress with parameter grouping and foreach optimizer.
Modification
Add
reduce_param_groups
refer from https://github.com/facebookresearch/detectron2/blob/main/detectron2/solver/build.pyEnable
foreach
when torch>=1.12BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
benchmark
TODO