[Refine] Dump all level logging messages to the log file. #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouzaida
reviewed
Aug 31, 2022
Comment on lines
+145
to
+151
| # dump the information to the logger file. | ||
| for name, param in self.named_parameters(): | ||
| print_log( | ||
| f'\n{name} - {param.shape}: ' | ||
| f"\n{self._params_init_info[param]['init_info']} \n ", | ||
| logger=logger_name, | ||
| level=logging.DEBUG) |
There was a problem hiding this comment.
It is necessary to check whether the message will fill the whole terminal if debug is set and whether this will make users unhappy.
There was a problem hiding this comment.
Since all level messages will be dumped to the log file, users can check the debug information in the saved file, I think only the advanced terminal user will set the log_level to debug, to see search the debug information in the terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Dump all level logging messages to the log file, and keep the messages in terminal matched with the log level.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward-compatibility of the downstream repos?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.
Checklist