-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Mlflow logging | Add possibility of optional calling of "after run" hooks. #1125
base: main
Are you sure you want to change the base?
Conversation
|
Hi! Please follow the guide in contributing.md to fix the lint error |
Hi @ihoholko, We'd like to express our appreciation for your valuable contributions to the mmengine. Your efforts have significantly aided in enhancing the project's quality. If you're on WeChat, we'd also love for you to join our community there. Just add our assistant using the WeChat ID: openmmlabwx. When sending the friend request, remember to include the remark "mmsig + Github ID". Thanks again for your awesome contribution, and we're excited to have you as part of our community! |
Thanks for your contribution, the modification of MLFLow makes sense to me, however, we need to reconsider the modifications for the runner. I believe the core issue lies in when to close the visualizer. It appears that closing it in the |
@HAOCHENYE should we create a new PR for fixing the MLFlow logging issue? It is currently a problem in mmdet: |
Mlflow Logging
Mlflow doesn't support such characters as
@
. Pull request fixes this by replacing@
with_at_
.after run
hooks.Current pipeline doesn't allow to log artifacts and perform test after
train
with active hooks. This PR fixes this by adding optinalcall_hook_after_run
totrain
andtest
methods. :