Issue1389 crash course package #1403
Conversation
|
@LoneMeertens , thank you for creating the pull request! The tests are indeed failing because the paths have changed. Let's change that once the structure of the new package has been finalised. I wonder if we could create a new package DetailedHouse to collect Example 1 - 10. Now, you have divided the examples across the exercises of the crash course, but for external people, this is not that relevant. We could follow the same approach as SimpleHouse: collecting all steps in the same package. SimpleHouse uses a simple RC model. DetailedHouse uses a detailed IDEAS building model. What do you think? |
|
@lucasverleyen Thank you for the feedback! Creating a DetailedHouse package to collect Examples 1–10 makes sense and aligns well with the SimpleHouse approach. I’ll work on modifying the structure accordingly. |
|
I was also thinking about the SimpleHouse.mo model that is in the original IBPSA library at the same level as the Tutorial package. I would suggest keeping the model there because we'll probably not change that model soon. The less we change compared to IBPSA, the easier it is to merge the latest changes of IBPSA into IDEAS. |
| points={{-45,12},{-38.5,12},{-38.5,15.7143},{-20,15.7143}}, | ||
| points={{-45,12},{-38.5,12},{-38.5,13.1429},{-20,13.1429}}, |
There was a problem hiding this comment.
I see quite some unintended changes, due to different Dymola versions. Sometimes Dymola changes other lines in the text if you save a model. However, it is a good practice to check the lines of code that you commit and only commit the lines that you really want to change. You can discard all other changes.
As there are many, and you will change the structure anyway, I propose to start from a new branch, which is easier than reverting these changes.
fixes #1389