hotfix for boptest in threshold #1262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is fine by me. Nice to see that you worked out #1260 and could nail down the problem. @Mathadon I think you mean 1e-8 instead of 0 (not 0.5)? I'd suggest documenting the motivation to use 1e-8, at least with a comment in the |
|
No I mean 0.5, since that's what Dave suggested. I'll add documentation. |
Mathadon
commented
May 3, 2022
|
1e-8 is fine, 0.5 was just a course trial. See #1264 though. |
|
Also @JavierArroyoBastida we can't update BOPTEST yet because this uses MSL4 and we don't yet have the tooling in BOPTEST parser to use OM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for #1260
@dhblum does this work too? I used 1e-8 instead of 0.5 for the threshold.
@JavierArroyoBastida do you agree with this change?
closes #1260