Revert pull request #1317 (expandable connectors) to provide a tempor…

…ary fix for issue #1328
open-ideas · Dec 7, 2023 · 7d74c32 · 7d74c32
1 parent 1211ea7
commit 7d74c32
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 24 deletions.
diff --git a/IDEAS/Buildings/Components/Interfaces/SolBus.mo b/IDEAS/Buildings/Components/Interfaces/SolBus.mo
@@ -1,5 +1,5 @@
 within IDEAS.Buildings.Components.Interfaces;
-expandable connector SolBus
+connector SolBus
   "Bus containing solar radiation for various incidence angles as well as external convection coefficients"
   parameter Boolean outputAngles = true "Set to false when linearising in Dymola only";
   IDEAS.Buildings.Components.Interfaces.RealConnector HDirTil(unit="W/(m2)",start=100) annotation ();
@@ -37,11 +37,6 @@ Connector that contains all solar irridiation information for one inclination an
 </html>", revisions="<html>
 <ul>
 <li>
-April 20, 2023 by Jelger Jansen:<br/>
-Make the connector expandable to avoid (pedantic check) warnings in Dymola 2022x.
-See issue <a href=https://github.com/open-ideas/IDEAS/issues/1317>#1317</a>
-</li>
-<li>
 November 28, 2019 by Ian Beausoleil-Morrison:<br/>
 Add RealConnector for coefficient for forced convection at exterior surface.
 See <a href=\"https://github.com/open-ideas/IDEAS/issues/1089\">

diff --git a/IDEAS/Buildings/Components/Interfaces/WeaBus.mo b/IDEAS/Buildings/Components/Interfaces/WeaBus.mo
@@ -1,5 +1,5 @@
 within IDEAS.Buildings.Components.Interfaces;
-expandable connector WeaBus "Data bus that stores weather data"
+connector WeaBus "Data bus that stores weather data"
   parameter Integer numSolBus;
   parameter Boolean outputAngles = true "Set to false when linearising in Dymola only";
 
@@ -83,11 +83,6 @@ Connector that contains all environment information for many inclinations and ti
    revisions="<html>
 <ul>
 <li>
-April 20, 2023 by Jelger Jansen:<br/>
-Make the connector expandable to avoid (pedantic check) warnings in Dymola 2022x.
-See issue <a href=https://github.com/open-ideas/IDEAS/issues/1317>#1317</a>
-</li>
-<li>
 November 28, 2019, by Ian Beausoleil-Morrison:<br/>
 Removed hConExt from weather bus because it is not calculated in ExtConvForcedCoeff.mo and ExteriorConvection.mo.<br/>
 Added wind speed and direction to weather bus.

diff --git a/IDEAS/Buildings/Components/Interfaces/WindowBus.mo b/IDEAS/Buildings/Components/Interfaces/WindowBus.mo
@@ -1,5 +1,5 @@
 within IDEAS.Buildings.Components.Interfaces;
-expandable connector WindowBus
+connector WindowBus
   "Bus containing inputs/outputs for linear window model"
   parameter Integer nLay = 3 "Number of window layers";
 
@@ -10,11 +10,6 @@ expandable connector WindowBus
   annotation (Documentation(revisions="<html>
 <ul>
 <li>
-April 20, 2023 by Jelger Jansen:<br/>
-Make the connector expandable to avoid (pedantic check) warnings in Dymola 2022x.
-See issue <a href=https://github.com/open-ideas/IDEAS/issues/1317>#1317</a>
-</li>
-<li>
 October 22, 2016, by Filip Jorissen:<br/>
 Revised documentation for IDEAS 1.0.
 </li>

diff --git a/IDEAS/Buildings/Components/Interfaces/ZoneBus.mo b/IDEAS/Buildings/Components/Interfaces/ZoneBus.mo
@@ -1,5 +1,5 @@
 within IDEAS.Buildings.Components.Interfaces;
-expandable connector ZoneBus
+connector ZoneBus
   replaceable package Medium =
     Modelica.Media.Interfaces.PartialMedium "Medium in the component";
   parameter Integer numIncAndAziInBus
@@ -57,11 +57,6 @@ heat and information between a zone and a surface.
 </html>", revisions="<html>
 <ul>
 <li>
-April 20, 2023 by Jelger Jansen:<br/>
-Make the connector expandable to avoid (pedantic check) warnings in Dymola 2022x.
-See issue <a href=https://github.com/open-ideas/IDEAS/issues/1317>#1317</a>
-</li>
-<li>
 August 10, 2020, by Filip Jorissen:<br/>
 Modifications for supporting interzonal airflow.
 See <a href=\"https://github.com/open-ideas/IDEAS/issues/1066\">