Update template for monolithic operator pages #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cjsha
commented
Aug 2, 2024
cjsha
commented
- MRef.extension modified to inherit contextTask info from MultiDeviceFactory for aggregate nodes as well as
- Remove rhs2116 and miniscope tutorial placeholders
- Point to later repo in source code
- Mustache templating refactored to have table and diagram partial templates to reuse reoccuring html patterns
- css modified to make headers more distinctive
- No more filtering in filter.yml - toc organized using toc.extension.js
- Not filter enums allows the cloud build to reflect my local build (which was coming out different because the api folder never clears)
- Replace the word "node" with "operator"
- node in diagram is now aligned with the input/output boxes and the grey arrows
- MRef.extension modified to inherit contextTask info from MultiDeviceFactory for aggregate nodes as well as - Remove rhs2116 and miniscope tutorial placeholders - Point to later repo in source code - Mustache templating refactored to have table and diagram partial templates to reuse reoccuring html patterns - css modified to make headers more distinctive - No more filtering in filter.yml - toc organized using toc.extension.js - Not filter enums allows the cloud build to reflect my local build (which was coming out different because the api folder never clears) - Replace the word "node" with "operator" - node in diagram is now aligned with the input/output boxes and the grey arrows
bparks13
approved these changes
Aug 2, 2024
|
|
||
| {{/oe.operatorType}} | ||
|
|
||
| {{#oe.hasSubOperators}} | ||
|
|
||
| <h2>Properties</h2> | ||
|
|
||
| <div>{{name.0.value}} is a aggregate operator. It comprises of the following sub-operators: </div> |
There was a problem hiding this comment.
These are good, we should probably take this wording and apply it to the User Guide pages too
|
Looks like the TOC for tutorials needs to be updated and have the lines for the placeholder tutorials removed. |
- Resolve broken links by removing files from the tutorials/toc.yml that don't exist
|
The |
- edit template to use the showWorkflow flag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.