fix(transfer): accidental extra identity defaulting during transfer #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianburth
approved these changes
Jan 9, 2025
Skarlso
approved these changes
Jan 9, 2025
jakobmoellerdev
added a commit
to jakobmoellerdev/ocm
that referenced
this pull request
Jan 9, 2025
…pen-component-model#1236) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it replaces open-component-model#1223 as it does not contain the revert for the normalization algorithm Introduces DisableExtraIdentityDefaulting which is enabled by default during transport because IsModifyElement is not enough to differentiate if the component version is allowed to be modified during transfer. #### Which issue(s) this PR fixes PR that tackles a case in which `ocm transfer cv` caused accidental defaults to the extra identity. --------- Co-authored-by: Uwe Krueger <[email protected]>
jakobmoellerdev
added a commit
to jakobmoellerdev/ocm
that referenced
this pull request
Jan 9, 2025
…pen-component-model#1236) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it replaces open-component-model#1223 as it does not contain the revert for the normalization algorithm Introduces DisableExtraIdentityDefaulting which is enabled by default during transport because IsModifyElement is not enough to differentiate if the component version is allowed to be modified during transfer. #### Which issue(s) this PR fixes PR that tackles a case in which `ocm transfer cv` caused accidental defaults to the extra identity. --------- Co-authored-by: Uwe Krueger <[email protected]>
ikhandamirov
pushed a commit
that referenced
this pull request
Jan 9, 2025
…1236) (#1237) <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it replaces #1223 as it does not contain the revert for the normalization algorithm Introduces DisableExtraIdentityDefaulting which is enabled by default during transport because IsModifyElement is not enough to differentiate if the component version is allowed to be modified during transfer. #### Which issue(s) this PR fixes PR that tackles a case in which `ocm transfer cv` caused accidental defaults to the extra identity. --------- <!-- markdownlint-disable MD041 --> #### What this PR does / why we need it Backports this change to v0.19 as it occurred there first #### Which issue(s) this PR fixes <!-- Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Ensures Transports also dont default with 0.19.z Co-authored-by: Uwe Krueger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
replaces #1223 as it does not contain the revert for the normalization algorithm
Introduces DisableExtraIdentityDefaulting which is enabled by default during transport because IsModifyElement is not enough to differentiate if the component version is allowed to be modified during transfer.
Which issue(s) this PR fixes
PR that tackles a case in which
ocm transfer cvcaused accidental defaults to the extra identity.