Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Copilot Secret Scanning, let's use always the same sample #1234

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Jan 9, 2025

What this PR does / why we need it

Although the text: specialsecret2 might not be used as real password, let's try to use always a more obvious placeholder: <my-secret-password>

Which issue(s) this PR fixes

fixes: https://github.com/open-component-model/ocm/security/secret-scanning/6

@hilmarf hilmarf requested a review from a team as a code owner January 9, 2025 10:48
@github-actions github-actions bot added area/documentation Documentation related size/s Small labels Jan 9, 2025
@hilmarf hilmarf added this to the 2025-Q1 milestone Jan 9, 2025
@hilmarf hilmarf enabled auto-merge (squash) January 9, 2025 10:50
@morri-son morri-son added the kind/chore chore, maintenance, etc. label Jan 9, 2025
@hilmarf hilmarf changed the title Copilot Secret Scanning, let's use always the same sample: chore: Copilot Secret Scanning, let's use always the same sample Jan 9, 2025
@hilmarf hilmarf added the kind/skip-release-notes Pull request will not appear in release notes label Jan 9, 2025
@hilmarf hilmarf merged commit 8a5f983 into open-component-model:main Jan 9, 2025
29 of 30 checks passed
@hilmarf hilmarf deleted the chore/secrets branch January 9, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation related kind/chore chore, maintenance, etc. kind/skip-release-notes Pull request will not appear in release notes size/s Small
Projects
Status: 🍺 Done
Development

Successfully merging this pull request may close these issues.

3 participants