-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: jfrog plugin + helm upload handler #1167
Merged
jakobmoellerdev
merged 17 commits into
open-component-model:main
from
jakobmoellerdev:feat/jfrog-plugin
Jan 8, 2025
Merged
feat: jfrog plugin + helm upload handler #1167
jakobmoellerdev
merged 17 commits into
open-component-model:main
from
jakobmoellerdev:feat/jfrog-plugin
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
kind/feature
new feature, enhancement, improvement, extension
size/l
Large
labels
Nov 29, 2024
jakobmoellerdev
force-pushed
the
feat/jfrog-plugin
branch
from
December 3, 2024 10:08
7724758
to
3764165
Compare
github-actions
bot
added
the
component/github-actions
Changes on GitHub Actions or within `.github/` directory
label
Dec 3, 2024
jakobmoellerdev
force-pushed
the
feat/jfrog-plugin
branch
from
December 3, 2024 10:24
3764165
to
2d14304
Compare
jakobmoellerdev
force-pushed
the
feat/jfrog-plugin
branch
from
December 5, 2024 13:48
2d14304
to
5d4199c
Compare
but still no tests
Skarlso
reviewed
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review before starting to play around with this.
Co-authored-by: Gergely Brautigam <[email protected]>
jakobmoellerdev
force-pushed
the
feat/jfrog-plugin
branch
from
December 18, 2024 08:25
d4af85a
to
6b2b379
Compare
jakobmoellerdev
force-pushed
the
feat/jfrog-plugin
branch
from
January 2, 2025 18:11
ba3fd39
to
c84fbf4
Compare
jakobmoellerdev
force-pushed
the
feat/jfrog-plugin
branch
from
January 6, 2025 09:00
c84fbf4
to
962ef14
Compare
jakobmoellerdev
force-pushed
the
feat/jfrog-plugin
branch
from
January 6, 2025 17:05
a17ec57
to
3100dc6
Compare
Skarlso
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done! :) Thanks for bearing with me. :D
jakobmoellerdev
merged commit Jan 8, 2025
ada5381
into
open-component-model:main
25 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Documentation related
component/github-actions
Changes on GitHub Actions or within `.github/` directory
kind/feature
new feature, enhancement, improvement, extension
size/l
Large
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Implements a JFrog Plugin that contains an uploader that is able to upload to JFrog Helm Chart Repositories (different from OCI).
Example Reference Upload configuration:
The plugin will be installable with
ocm install plugin ghcr.io/open-component-model/ocm//ocm.software/plugins/jfrogplugin
as it is added to our parallel build list.
Since during development (while this PR does not get merged and we dont have an RC) you cannot use this command, you can choose to either push your own version of the plugin (there are commands in the new makefile), or you can run (also in the new makefile):
which will do a build and install locally so you can use it without fetching it remotely
Once added, you can run something like
to introspect it.
The plugin is now able to be used by OCM.
The plugin registers itself for the mediaTypes of a Helm Chart TGZ as well as OCI artifacts to convert them. Notably, the OCI artifact conversion is lossy because the provenance data is omitted, so back and forth conversion while maintaining digests might not always be possible in a fully trusted environment
Which issue(s) this PR fixes
fix #1116