-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rework release note handling #1139
Merged
jakobmoellerdev
merged 1 commit into
open-component-model:main
from
jakobmoellerdev:chore/rework-release-note-handling
Nov 26, 2024
Merged
chore: rework release note handling #1139
jakobmoellerdev
merged 1 commit into
open-component-model:main
from
jakobmoellerdev:chore/rework-release-note-handling
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
chore
component/github-actions
Changes on GitHub Actions or within `.github/` directory
size/m
Medium
labels
Nov 25, 2024
hilmarf
reviewed
Nov 26, 2024
hilmarf
reviewed
Nov 26, 2024
hilmarf
previously approved these changes
Nov 26, 2024
jakobmoellerdev
dismissed
hilmarf’s stale review
November 26, 2024 08:55
The merge-base changed after approval.
jakobmoellerdev
force-pushed
the
main
branch
from
November 26, 2024 08:55
676bdc1
to
4205242
Compare
jakobmoellerdev
force-pushed
the
chore/rework-release-note-handling
branch
2 times, most recently
from
November 26, 2024 09:03
20ac0d0
to
9863ce7
Compare
hilmarf
previously approved these changes
Nov 26, 2024
jakobmoellerdev
force-pushed
the
chore/rework-release-note-handling
branch
from
November 26, 2024 12:15
9c2ea53
to
059e375
Compare
frewilhelm
reviewed
Nov 26, 2024
hilmarf
previously approved these changes
Nov 26, 2024
reworks release note management based on github release note api It does this in the following way: 1. Creates a tag on cutoff that is annotated 2. Calls the Github Release Note API together with a release note configuration file (very similar to drafter but allows us to specify a previous tag) 3. Generates the notes for the current branch based on the last found tag.
jakobmoellerdev
force-pushed
the
chore/rework-release-note-handling
branch
from
November 26, 2024 13:54
059e375
to
1e236cc
Compare
frewilhelm
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/github-actions
Changes on GitHub Actions or within `.github/` directory
kind/chore
chore, maintenance, etc.
size/m
Medium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
reworks release note management based on github release note api
It does this in the following way:
This has the advantage that we can explicitly determine which release notes are generated from when to when and also use the contributors fields.
TODO:
Which issue(s) this PR fixes