Skip to content

Commit

Permalink
Merge branch 'main' into chore/remove-explicit-release-note-action
Browse files Browse the repository at this point in the history
  • Loading branch information
hilmarf authored Nov 20, 2024
2 parents ad346fb + 1fb2f09 commit cf0c2e6
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 5 deletions.
6 changes: 5 additions & 1 deletion .github/config/labeler.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,8 @@ chore:
dependencies:
- any:
- head-branch: 'dependencies/*'
- head-branch: 'dependabot/*'
- head-branch: 'dependabot/*'
github-actions:
- any:
- changed-files:
- '.github/**'
2 changes: 1 addition & 1 deletion .github/workflows/pull-request.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ permissions:

jobs:
branch-name-labeler:
name: Label PR based on branch name
name: Label PR based on Config
permissions:
contents: read
pull-requests: write
Expand Down
12 changes: 10 additions & 2 deletions cmds/ocm/commands/ocmcmds/common/addhdlrs/rscs/elements.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ func (h *ResourceSpecHandler) Set(v ocm.ComponentVersionAccess, r addhdlrs.Eleme
SourceRefs: compdescv2.ConvertSourcerefsTo(spec.SourceRefs),
}
opts := h.getModOpts()
if spec.SkipDigestGeneration {
if spec.Options.SkipDigestGeneration {
opts = append(opts, ocm.SkipDigest()) //nolint:staticcheck // skip digest still used for tests
}
/*
Expand Down Expand Up @@ -132,8 +132,16 @@ type ResourceSpec struct {

addhdlrs.ResourceInput `json:",inline"`

// additional process related options
// Options describes additional process related options
// see ResourceOptions for more details.
Options ResourceOptions `json:"options,omitempty"`
}

// ResourceOptions describes additional process related options
// which reflect the handling of the resource without describing it directly.
// Typical examples are any options that require specific changes in handling of the resource
// but are not reflected in the resource itself (outside of side effects)
type ResourceOptions struct {
// SkipDigestGeneration omits the digest generation.
SkipDigestGeneration bool `json:"skipDigestGeneration,omitempty"`
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ labels:
resources:
- name: text
type: PlainText
skipDigestGeneration: true
labels:
- name: city
value: Karlsruhe
Expand All @@ -23,6 +22,8 @@ resources:
input:
type: file
path: testdata
options:
skipDigestGeneration: true
- name: data
type: PlainText
input:
Expand Down

0 comments on commit cf0c2e6

Please sign in to comment.