Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] add lveval benchmark #914

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

yuantao2108
Copy link
Contributor

@yuantao2108 yuantao2108 commented Feb 23, 2024

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

Merge LVEval benchmark to opencompass.

Modification

Please briefly describe what modification is made in this PR.

BC-breaking (Optional)

Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here and update the documentation.

Checklist

Before PR:

  • Pre-commit or other linting tools are used to fix the potential lint issues.
  • Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
  • The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  • The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

  • If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects.
  • CLA has been signed and all committers have signed the CLA in this PR.

dict(
type=LVEvalcmrcDataset,
abbr="LVEval_" + name_len,
path="Infinigence/LVEval",
Copy link
Collaborator

@Mor-Li Mor-Li Feb 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR. I noticed the dataset path (Infinigence/LVEval) isn't relative to our project's root. Could you please update it to a relative path, like ./data/LVEval, for better consistency and accessibility?

Also, I can't access the dataset at this path. Could you provide a sample or mock data for testing purposes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a huggingface data path, which should be directly loaded by hf datasets lib. Could you please access or download from this URL: https://huggingface.co/datasets/Infinigence/LVEval ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the misunderstanding regarding your data path. My mistake, and I appreciate your patience.

@Mor-Li Mor-Li changed the title add lveval benchmark [Feature] add lveval benchmark Feb 26, 2024
@tonysy
Copy link
Collaborator

tonysy commented Feb 28, 2024

Copy link
Collaborator

@Mor-Li Mor-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As inline comments.

configs/eval_bluelm_32k_lveval.py Outdated Show resolved Hide resolved
configs/eval_llama2_7b_lveval.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Mor-Li Mor-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mor-Li Mor-Li merged commit bbec7d8 into open-compass:main Mar 4, 2024
9 checks passed
Leymore pushed a commit that referenced this pull request Apr 23, 2024
* add lveval benchmark

* add LVEval readme file

* update LVEval readme file

* Update configs/eval_bluelm_32k_lveval.py

* Update configs/eval_llama2_7b_lveval.py

---------

Co-authored-by: yuantao <[email protected]>
Co-authored-by: Mo Li <[email protected]>
liuyaox pushed a commit to liuyaox/opencompass that referenced this pull request Jun 26, 2024
* add lveval benchmark

* add LVEval readme file

* update LVEval readme file

* Update configs/eval_bluelm_32k_lveval.py

* Update configs/eval_llama2_7b_lveval.py

---------

Co-authored-by: yuantao <[email protected]>
Co-authored-by: Mo Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants