Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing argument to erase/1 #291

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add missing argument to erase/1 #291

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/open_api_spex/plug/cache.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ defmodule OpenApiSpex.Plug.Cache do
@spec refresh() :: :ok
def refresh do
adapter = adapter()
adapter.erase()
adapter.erase(adapter)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will stop it from crashing, but not actually clear the cache.

The refresh function should take a spec_module argument and pass it through to adapter, or alternatively we should add an erase_all callback to the adapter behaviour that doesn't require the spec module to be given.

end
end

Expand Down