Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Http auth redirect & provide nice looking UI feedback (fixes #84) #85

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

opatry
Copy link
Owner

@opatry opatry commented Oct 29, 2024

Description

  • redirect was done to minimize the time the auth code is visible to the user in the URL but the callbackFlow result was immediately sent not waiting for redirect to finish. Postponing the result once the redirect is done allows providing proper user feedback from browser instead of shutdown server state.
  • was also the opportunity to provide nice looking user feedback with proper HTML & assets
  • on macOS, the error & success automatically redirects to the app

Checklist

  • I have read the CONTRIBUTING guide
  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing

@opatry opatry force-pushed the 84-fix-http-auth-redirect branch from dc0bcdd to a52867a Compare October 29, 2024 11:33
@opatry opatry requested a review from AmauryC October 29, 2024 11:33
@opatry opatry merged commit 06329b9 into main Oct 29, 2024
2 checks passed
@opatry opatry deleted the 84-fix-http-auth-redirect branch October 29, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix HTTP redirect to hide secrets from URL being triggered after server is shutdown 🔒
1 participant