Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sync test linked to network availability & fix Post request response #81

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

opatry
Copy link
Owner

@opatry opatry commented Oct 28, 2024

Description

Relying on "request count" in test to determine which should be a "no network connection" or not wasn't ideal.
Making things explicit is better.
Also, the Post request was returning a response list but should have been a single TaskList.

Note: this is still a bit weird/fragile to rely on endpoint url & Http verb to determine the result.
Typically, Get task list here always return empty, but wouldn't after second sync() call.

This is left for later if a better pattern emerges.

Checklist

  • I have read the CONTRIBUTING guide
  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing

@opatry opatry merged commit a2e18d9 into main Oct 28, 2024
2 checks passed
@opatry opatry deleted the task-repository-sync-test-improvements branch October 28, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant