Improve sync test linked to network availability & fix Post
request response
#81
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relying on "request count" in test to determine which should be a "no network connection" or not wasn't ideal.
Making things explicit is better.
Also, the
Post
request was returning a response list but should have been a singleTaskList
.Note: this is still a bit weird/fragile to rely on endpoint url & Http verb to determine the result.
Typically,
Get
task list here always return empty, but wouldn't after secondsync()
call.This is left for later if a better pattern emerges.
Checklist