Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local only tasks sync #76

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Fix local only tasks sync #76

merged 5 commits into from
Oct 28, 2024

Conversation

opatry
Copy link
Owner

@opatry opatry commented Oct 28, 2024

Description

There were several issues:

  • local list id not properly managed to link to remote id (leading to task being moved in default list)
  • notes, due date and other fields weren't transfered from local to remote task
  • no proper dispatch of IO thread for API calls
  • syncing local only completed lead to weird remote task status (completed but not hidden, position not following the 099999 pattern
  • local only task processing was also made several times not taking into account the associated task list

Took the opportunity of these change to distinguish insert from update (using upsert pattern in such a case).
Also added TaskList & Task factories avoiding the use of read only/output only fields of the API data class bindings.

Checklist

  • I have read the CONTRIBUTING guide
  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing

@opatry opatry force-pushed the fix-local-only-sync branch from 350e925 to 0221c30 Compare October 28, 2024 10:12
@opatry opatry merged commit 6e0d758 into main Oct 28, 2024
1 check passed
@opatry opatry deleted the fix-local-only-sync branch October 28, 2024 10:12
@opatry opatry linked an issue Oct 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local first tasks are synced in the wrong task list after sign-in
1 participant