Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize symlink target #768

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Sanitize symlink target #768

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b11fe46
Rewrite symlink sanitization logic
Feb 12, 2024
3195805
Add back fix_symlink as a wrapper to let tests run.
e3krisztian Feb 14, 2024
cd167e8
disable `ruff` after reformatting - ruff problems are still remaining
e3krisztian Feb 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions unblob/extractor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,12 @@ def is_recursive_link(path: Path) -> bool:
return False


def fix_symlink(path: Path, outdir: Path, task_result: TaskResult) -> Path:
# This is a temporary function for existing unit tests in tests/test_extractor.py
fix_extracted_directory(outdir, task_result)
return path


qkaiser marked this conversation as resolved.
Show resolved Hide resolved
def sanitize_symlink_target(base_dir, current_dir, target):
# Normalize all paths to their absolute forms
base_dir_abs = os.path.abspath(base_dir)
Expand Down