Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: plistlib.loads #696

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

bugfix: plistlib.loads #696

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6df95d
bugfix: plistlib.loads
pome-ta May 1, 2023
ec24ad8
Go all-in on pathlib
pome-ta May 2, 2023
a71f89e
info_plist -> plist
pome-ta May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion scripts/sysinfo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import os
pome-ta marked this conversation as resolved.
Show resolved Hide resolved
import sys
import platform
from pathlib import Path
from objc_util import ObjCClass, on_main_thread
import clipboard

Expand All @@ -12,7 +13,8 @@ def get_pythonista_version_info():

try:
plist_path = os.path.abspath(os.path.join(sys.executable, '..', 'Info.plist'))
Copy link
Contributor

@cclauss cclauss May 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
plist_path = os.path.abspath(os.path.join(sys.executable, '..', 'Info.plist'))

plist = plistlib.readPlist(plist_path)
plist_data = Path(plist_path).read_bytes()
plist = plistlib.loads(plist_data)
Copy link
Contributor

@cclauss cclauss May 1, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
plist_data = Path(plist_path).read_bytes()
plist = plistlib.loads(plist_data)
info_plist = plistlib.loads((Path(sys.executable).parent / "Info.plist").read_bytes())


version = plist['CFBundleShortVersionString']
bundle_version = plist['CFBundleVersion']
Expand Down