Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix NoneType exception on timeincrement #607

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Rdornier
Copy link
Contributor

@Rdornier Rdornier commented Jan 8, 2025

Fixes #606

Added a None check in that line

@will-moore
Copy link
Member

Thanks for the report and fix.
I can't seem to reproduce this on any images I've tested with (I can't even set the timeIncrement value to None on a test image using example at https://forum.image.sc/t/how-to-correctly-set-a-timeincrement-for-omero-pixels/101600).
Do you see this on all time-lapse images?

However, the fix looks like the right fix for this error, so I'm happy to approve...

Copy link
Member

@will-moore will-moore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed on merge-ci and tested loading various time-lapse images. Images and Timestamps loading without errors.

@will-moore will-moore merged commit adc1ab5 into ome:master Jan 9, 2025
1 check passed
@will-moore
Copy link
Member

Released as omero-figure 7.2.1

@Rdornier
Copy link
Contributor Author

Thanks a lot for the quick merge & release, Will !

Do you see this on all time-lapse images?

No, only on specific images coming from an Incucyte microscope.

I can't seem to reproduce this on any images I've tested with

I cannot share the problematic data. However, if you create a timelapse image on Fiji, you can get the same error.
Here is a dummy timelapse timelapse-test.zip that should produce the bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timelapse images cannot be added in any new figure
2 participants