Apply ruff rules to Python scripts #198
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
52a38a2 to
735417e
Compare
sbesson
reviewed
Jan 8, 2025
There was a problem hiding this comment.
From an initial code review, I don't see concerning changes. Given the modifications to the code generation utilities, we'll need to confirm that the generated classes are unmodified by this change for all supported Python versions.
Several contributions are made against files of a package which has just been deprecated and are scheduled for removal in an upcoming release (setup.py, ome_model/experimental.py, test/unit/*) - see #194 for more details. Given the scope of this work, we might pioritize the clean up of these classes first and update you when this is completed and conflicts should be resolved so that only changes against xsd-fu utility are evaluated
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
735417e to
760ee8b
Compare
F401 imported but unused
E402 Module level import not at top of file
E703 Statement ends with an unnecessary semicolon
W291 Trailing whitespace
W293 Blank line contains whitespace
W391 Too many newlines at end of file
C414 Unnecessary `list()` call within `sorted()`
C419 Unnecessary list comprehension
EXE001 Shebang is present but file is not executable
ISC002 Implicitly concatenated string literals over multiple lines
PIE790 Unnecessary `pass` statement
PIE810 Call `startswith` once with a `tuple`
SIM103 Return the condition directly
bool() is not required as the type of expressions is already bool
SIM110 Use `return any()` instead of `for` loop
SIM118 Use `key in dict` instead of `key in dict.keys()`
SIM401 Use `.get(...)` instead of an `if` block
FURB142 Use of `set.add()` in a for loop
FURB148 `enumerate` index is unused, use `for x in y` instead
UP003 Use `str` instead of `type("")`
UP004 Class inherits from `object`
UP008 Use `super()` instead of `super(__class__, self)`
UP009 UTF-8 encoding declaration is unnecessary
The default encoding of Python 3 is UTF-8, use it! Then there's no need to explicitely declare the encoding. The modified file is a plain ASCII file, by the way.
UP024 Replace aliased errors with `OSError`
UP034 Avoid extraneous parentheses
DimitriPapadopoulos
force-pushed
the
ruff
branch
from
760ee8b to
120f7f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm assuming all scripts are Python 3 scripts, except this one:
specification/src/main/resources/transforms/util/write-transforms.py
The latter has been marked as a Python 2 script.