Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up GitHub actions config #107

Merged
merged 8 commits into from
Nov 21, 2024
Merged

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 19, 2024

Minor cleans to the GH actions config:

  • Bump versions
  • Some changes to match the latest napari plugin cookiecutter template
  • Drop master
  • Don't fail fast

Also add ome-zarr<0.8.3 to un-break tests (see #108 for issue)

@dstansby dstansby force-pushed the clean-gh-actions branch 5 times, most recently from bf038cb to edce9f8 Compare June 6, 2024 17:42
@dstansby
Copy link
Contributor Author

dstansby commented Jun 6, 2024

Well I can't work out what's going wrong with the windows tests here... if someone has a windows machine they can use to test/fix locally it would be very appreciated!

@dstansby
Copy link
Contributor Author

This has been sitting here so long that I don't think I'm going to make any changes to it now. Could someone either:

  1. Merge it
  2. Add their own changes and merge it
  3. Close it as not wanted

?

(sorry to be a bit blunt, but I think better to be honest that I'm not going to work on this any time soon!)

@jburel
Copy link
Member

jburel commented Nov 21, 2024

We have a large number of repositories and some PR might take longer that required to review.
Assigning a reviewer when opening a PR is a good way to raise awareness

@dstansby
Copy link
Contributor Author

Folks without commit rights don't have permission to assign reviewers unfortunately 😞

@jburel
Copy link
Member

jburel commented Nov 21, 2024

In that case maybe a ping in the description it will help
Thanks

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been sitting here so long that I don't think I'm going to make any changes to it now.

Of course very much your right, @dstansby 😄 but last comment being "Well I can't work out what's going wrong ... here" didn't give us much to go on.

Anyhoo, I've pushed the change above. Happy to discuss here at the hackathon if there are any lingering coordination thoughts.

libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 \
libxcb-xinerama0 libxcb-xinput0 libxcb-xfixes0
# these libraries enable testing on Qt on linux
- uses: tlambert03/setup-qt-libs@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. TIL. (Kudos to @tlambert03)

@joshmoore joshmoore merged commit 0bf3625 into ome:main Nov 21, 2024
14 checks passed
@dstansby dstansby deleted the clean-gh-actions branch November 21, 2024 10:44
@dstansby
Copy link
Contributor Author

Sorry for my negative language above, it was unfair on maintainers and I shouldn't have said it. What I should have said is just "I don't have time to work on this myself, so maintainers should feel free to do as they see fit" (including just leaving this open as is).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants