-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up GitHub actions config #107
Conversation
da8700f
to
df42754
Compare
bf038cb
to
edce9f8
Compare
Well I can't work out what's going wrong with the windows tests here... if someone has a windows machine they can use to test/fix locally it would be very appreciated! |
edce9f8
to
b63a80a
Compare
This has been sitting here so long that I don't think I'm going to make any changes to it now. Could someone either:
? (sorry to be a bit blunt, but I think better to be honest that I'm not going to work on this any time soon!) |
We have a large number of repositories and some PR might take longer that required to review. |
Folks without commit rights don't have permission to assign reviewers unfortunately 😞 |
In that case maybe a ping in the description it will help |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been sitting here so long that I don't think I'm going to make any changes to it now.
Of course very much your right, @dstansby 😄 but last comment being "Well I can't work out what's going wrong ... here" didn't give us much to go on.
Anyhoo, I've pushed the change above. Happy to discuss here at the hackathon if there are any lingering coordination thoughts.
libxcb-image0 libxcb-keysyms1 libxcb-randr0 libxcb-render-util0 \ | ||
libxcb-xinerama0 libxcb-xinput0 libxcb-xfixes0 | ||
# these libraries enable testing on Qt on linux | ||
- uses: tlambert03/setup-qt-libs@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. TIL. (Kudos to @tlambert03)
Sorry for my negative language above, it was unfair on maintainers and I shouldn't have said it. What I should have said is just "I don't have time to work on this myself, so maintainers should feel free to do as they see fit" (including just leaving this open as is). |
Minor cleans to the GH actions config:
master
Also add
ome-zarr<0.8.3
to un-break tests (see #108 for issue)