Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix -Zminimal-versions #280

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

paolobarbolini
Copy link
Contributor

serde_json::Value started implementing Hash starting from v1.0.118

@oli-obk
Copy link
Owner

oli-obk commented Dec 4, 2024

While you're at it, can you add this flag to the nightly CI?

@oli-obk oli-obk merged commit d6b186c into oli-obk:main Dec 4, 2024
6 checks passed
@weihanglo
Copy link
Contributor

You might want direct-minimal-versions instead

@ia0
Copy link

ia0 commented Dec 4, 2024

Thanks for the PR! I just hit this issue. For reference this was introduced by #271. And we could argue that serde_json should have bumped the minor version for that, but that's orthogonal.

@paolobarbolini
Copy link
Contributor Author

And we could argue that serde_json should have bumped the minor version for that, but that's orthogonal.

I don't know why but David never bumps minor version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants