User counters / actual clues fix #6276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| value Decimal @db.Decimal(13, 3) | ||
|
|
||
| @@id([user_id, key]) | ||
| @@unique([user_id, key]) |
There was a problem hiding this comment.
The @@unique([user_id, key]) is redundant because @@id([user_id, key]) already ensures uniqueness for the combination of user_id and key. Consider removing the @@unique constraint.
src/mahoji/lib/userCounter.ts
Outdated
| @@ -0,0 +1,23 @@ | |||
| export async function incrementUserCounter(_userID: string, _key: string, incrementUserCounter: number) { | |||
There was a problem hiding this comment.
The parameter incrementUserCounter should be renamed to something more descriptive like incrementValue to avoid confusion with the function name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changes:
Other checks: