[IMP] BorderEditorWidget: Reset position on close #5457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, once we used the border widget from the top bar to add a
border and the border position is set (i.e. you already used the
widget once), changing any other parameter will dispatch the change.
This is quite infuriating when trying to set very different borders
in succession since if you only change the color, it will dispatch
a change of border even though you did not have a chance to change
the type of position beforehand. This creates situations where you
need additional steps to get to the wanted result.
E.g.
Add an external border on A1
Select A2 to add a bottom border in another color
-> you either have to change the color first and then it applied an
external border or you first change the type of border and it applies
it then you have to open the widget again to select the right color,
which will end up giving the expected result.
This revision ensures that the position type is reset when closing
the border widget so that the user can always choose which type
of border to apply without frustrating and unexpected steps.
Task: 4475869
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, once we used the border widget from the top bar to add a border and the border position is set (i.e. you already used the widget once), changing any other parameter will dispatch the change.
This is quite infuriating when trying to set very different borders in succession since if you only change the color, it will dispatch a change of border even though you did not have a chance to change the type of position beforehand. This creates situations where you need additional steps to get to the wanted result.
E.g.
-> you either have to change the color first and then it applied an external border or you first change the type of border and it applies it then you have to open the widget again to select the right color, which will end up giving the expected result.
This revision ensures that the position type is reset when closing the border widget so that the user can always choose which type of border to apply without frustrating and unexpected steps.
Task: 4475869
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist